Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: increase BigInt parsing precision #3080

Merged
merged 2 commits into from
Aug 10, 2023
Merged

vm: increase BigInt parsing precision #3080

merged 2 commits into from
Aug 10, 2023

Conversation

AnnaShaleva
Copy link
Member

Follow the neo-project/neo#2883.

@AnnaShaleva AnnaShaleva added the vm VM tasks/bugs/issues label Aug 3, 2023
@AnnaShaleva AnnaShaleva added this to the v0.102.0 milestone Aug 3, 2023
@AnnaShaleva
Copy link
Member Author

Hardfork-related code depends on #3056 I'll update it soon.

@AnnaShaleva AnnaShaleva marked this pull request as draft August 7, 2023 07:51
@AnnaShaleva AnnaShaleva marked this pull request as ready for review August 8, 2023 15:53
@AnnaShaleva
Copy link
Member Author

Depends on #3056, but can be reviewed, the code itself is ready and waiting for the C# reference PR to settle.

@AnnaShaleva
Copy link
Member Author

Ready for review.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3080 (624f193) into master (562293c) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
- Coverage   84.73%   84.64%   -0.10%     
==========================================
  Files         329      329              
  Lines       43919    43924       +5     
==========================================
- Hits        37216    37179      -37     
- Misses       5191     5233      +42     
  Partials     1512     1512              
Files Changed Coverage Δ
pkg/config/hardfork.go 100.00% <ø> (ø)
pkg/core/native/std.go 96.82% <100.00%> (ø)
pkg/vm/stackitem/json.go 96.45% <100.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit 11c0f13 into master Aug 10, 2023
13 of 18 checks passed
@roman-khimov roman-khimov deleted the extend-int-prec branch August 10, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants