feat(schematics): create local project tsconfigs for typings #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
approved these changes
Nov 23, 2018
| types = types.concat( | ||
| ...getTsConfigs(project).map(tsconfigPath => { | ||
| const tsconfig = readJsonInTree(host, tsconfigPath); | ||
| return tsconfig.compilerOptions.types || []; |
There was a problem hiding this comment.
I think the right thing to do is to set the whole thing to undefined if any of the files have it set to undefined.
FrozenPandaz
force-pushed
the
tsconfigs
branch
from
b39ef34 to
303ce65
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Typings conflict and get overwritten when
jestorcypressare used.The only
tsconfig.json(Which is the only filename IDEs/tsserverwill recognize) is in the root directory meaning the whole workspace is subject to the same configuration within the IDE.Expected Behavior
Local
tsconfig.jsonfiles are created in every project root and define the appropriate types for each project. These files extend the roottsconfig.jsonand are mainly responsible for typings.tsconfig.(app|lib|spec|e2e).jsonfiles will extend off of the localtsconfigA migration is written which will update existing
tsconfigsand create new ones.I am drafting a wiki page here: https://github.com/FrozenPandaz/nx/wiki/Workspace-Organization#tsconfigs
Issue
Fixes #816