Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): support commits that does are not conventional commits #29658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tandrup
Copy link

@tandrup tandrup commented Jan 17, 2025

This allows users with repos that are a mix of conventional commits and other commits to configure that non-conventional commits will result in for example a patch version bump.

Current Behavior

Currently any commit that does match the conventional commit regex is dropped, and does not cause a version bump.

Expected Behavior

Due the content of our monorepo we have a mix of conventional commits and other commits. With this change we will be able to configure that a non-conventional commit should cause for example a patch semver version bump.
The default behaviour remains the same and will not bump versions for non-conventional commits.

Related Issue(s)

Haven't been able to find any.

@tandrup tandrup requested a review from a team as a code owner January 17, 2025 09:26
@tandrup tandrup requested a review from Cammisuli January 17, 2025 09:26
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 9:32am

Copy link

nx-cloud bot commented Jan 17, 2025

View your CI Pipeline Execution ↗ for commit 1a286ce.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 38m 3s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 11s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=bb03e... ✅ Succeeded 39s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 36s View ↗
nx documentation --no-dte ✅ Succeeded 1m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-17 10:18:21 UTC

…mmits

This allows users with repos that are a mix of conventional commits and other commits to configure that non-conventional commits will result in for example a patch version bump.
@tandrup tandrup force-pushed the non-conventional-commits branch from 5b0650c to 1a286ce Compare January 17, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant