Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: tfm for nrf54l15dk #634

Merged
merged 5 commits into from
Nov 7, 2024
Merged

samples: tfm for nrf54l15dk #634

merged 5 commits into from
Nov 7, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Oct 24, 2024 •
edited by totyz
Loading

move mfg partition to non secure storage in pm static

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: v2.8-branch

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: nrf54l_ns

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Oct 24, 2024
@ktaborowski ktaborowski changed the title samples: move mfg partition samples: tfm for nrf54l15dk Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 0 B 140.78 KB 0 B
ROM 56 B 510.5 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 140.77 KB 0 B
ROM 56 B 499.63 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 0 B 118.48 KB 0 B
ROM 64 B 459.97 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 92.3 KB 0 B
ROM 64 B 365.62 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 87.66 KB 0 B
ROM 120 B 296.45 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 0 B 102.45 KB 0 B
ROM 120 B 372.29 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.31 KB 0 B
ROM 64 B 351.36 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 0 B 118 KB 0 B
ROM 64 B 450.67 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 0 B 102.93 KB 0 B
ROM 64 B 368.3 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 0 B 141.65 KB 0 B
ROM 56 B 515.73 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 0 B 141.62 KB 0 B
ROM 56 B 507.19 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 119.23 KB 0 B
ROM 64 B 465.7 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 92.76 KB 0 B
ROM 64 B 366.65 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 0 B 87.95 KB 0 B
ROM 120 B 299.44 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 0 B 103.03 KB 0 B
ROM 120 B 378.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 0 B 111.48 KB 0 B
ROM 64 B 395.39 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 96.56 KB 0 B
ROM 64 B 311.89 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 0 B 135.25 KB 0 B
ROM 56 B 461.19 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 135.23 KB 0 B
ROM 56 B 453.73 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 0 B 112.98 KB 0 B
ROM 64 B 410.69 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 86.64 KB 0 B
ROM 64 B 310.47 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 82 KB 0 B
ROM 120 B 241.01 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 0 B 96.92 KB 0 B
ROM 120 B 320.75 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 0 B 117.03 KB 0 B
ROM 64 B 444.94 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 102.25 KB 0 B
ROM 64 B 367.3 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 91.52 KB 91.52 KB 0 B
ROM 315.8 KB 315.8 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 86.89 KB 86.89 KB 0 B
ROM 247.59 KB 247.59 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 101.67 KB 101.67 KB 0 B
ROM 323.42 KB 323.42 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 116.25 KB 116.25 KB 0 B
ROM 395.12 KB 395.12 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 101.47 KB 101.47 KB 0 B
ROM 317.48 KB 317.48 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 140 KB 140 KB 0 B
ROM 460.9 KB 460.9 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 140 KB 140 KB 0 B
ROM 458.2 KB 458.2 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 117.7 KB 117.7 KB 0 B
ROM 410.14 KB 410.14 KB 0 B

@github-actions github-actions bot added the tests label Oct 24, 2024
@ktaborowski ktaborowski force-pushed the nrf54l15dk_tfm branch 3 times, most recently from 66b9659 to 3587568 Compare October 30, 2024 12:05
ktaborowski
ktaborowski commented Nov 4, 2024
View reviewed changes
samples/sid_end_device/pm_static_nrf54l15dk_nrf54l15_cpuapp_ns.yml
Comment on lines -1 to -3
mfg_storage:
address: 0x17a000
end_address: 0x17b000
Copy link
Contributor Author

@ktaborowski ktaborowski Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mfg_storage now has the same address as in nrf54l15dk (without ns)

@ktaborowski ktaborowski force-pushed the nrf54l15dk_tfm branch 2 times, most recently from 857bfb6 to 78c7b73 Compare November 4, 2024 12:22
ktaborowski
ktaborowski commented Nov 4, 2024
View reviewed changes
subsys/config/common/src/app_ble_config.c Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMPORTANT: changes in this file will affect all platforms!

@ktaborowski ktaborowski marked this pull request as ready for review November 4, 2024 13:14
@ktaborowski ktaborowski force-pushed the nrf54l15dk_tfm branch 2 times, most recently from 435cbe1 to a8f1e0a Compare November 5, 2024 10:07
@totyz
Copy link
Contributor

totyz commented Nov 5, 2024

Cert tests: https://jenkins-ncs.nordicsemi.no/job/KRKNG/job/Sidewalk/job/test-sdk-sidewalk/job/test-branch/262/

@ktaborowski
tests: fix nrf54l15dk in mfg test
25d8c82 
Add configs for tlv module

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
tests: add support for nrf54l15 ns variant
99fc1a8 
[KRKNWK-19489]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
common: fill ble config structure
7011972 
sid api uses nested structures form ble_cfg

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
samples: support for nrf54l15 with tfm
e5af1f6 
[KRKNWK-19489]
Fix faults after application start.
Align mfg address with non tfm variant.
Disable logs in tf-m, pins are needed for Semtech.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
config: add secure key storage with tf-m
4376c2b 
[KRKNWK-19489]

Signed-off-by: Krzysztof Taborowski <[email protected]>
totyz
totyz approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LQTM.
No regression found in tests.
Smoke tests for _ns platform PASSED.

@ktaborowski ktaborowski merged commit 46b4ea3 into nrfconnect:main Nov 7, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totyz totyz totyz approved these changes

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

Assignees
No one assigned
Labels
func-integration source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaborowski @totyz @RobertGalatNordic