pal: switch to multi-advertising BLE API

[konradderda]

This commit prepares PAL to be used alongside other BLE instances.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket: KRKNWK-19430

Self review

• There is no commented code.
• There are no TODO/FIXME comments without associated issue ticket.
• Commits are properly organized.
• Change has been tested.
• Tests were updated (if applicable).

[konradderda]

Regarding Change has been tested. tick - The device has registered and sent test message to cloud but I do not possess enough experience to test the change thoroughly.

[github-actions]

Sample		diff	used	total
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only	RAM	1.16 KB	92.73 KB	0 B
	ROM	8.25 KB	324.58 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release	RAM	1.16 KB	88.1 KB	0 B
	ROM	7.51 KB	255.5 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release	RAM	1.16 KB	102.88 KB	0 B
	ROM	7.51 KB	331.33 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo	RAM	1.16 KB	118.24 KB	0 B
	ROM	8.28 KB	453.9 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only	RAM	1.16 KB	103.46 KB	0 B
	ROM	8.26 KB	376.25 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut	RAM	1.16 KB	141.99 KB	0 B
	ROM	8.32 KB	519.51 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure	RAM	1.16 KB	141.98 KB	0 B
	ROM	8.31 KB	511.82 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello	RAM	1.16 KB	119.69 KB	0 B
	ROM	8.26 KB	468.91 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only	RAM	1.16 KB	93.51 KB	0 B
	ROM	8.27 KB	374.58 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release	RAM	1.16 KB	88.88 KB	0 B
	ROM	7.54 KB	304.55 KB	0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release	RAM	1.16 KB	103.66 KB	0 B
	ROM	7.52 KB	380.37 KB	0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only	RAM	2.07 KB	108.38 KB	0 B
	ROM	3.38 KB	354.88 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.demo	RAM	2.34 KB	120.34 KB	0 B
	ROM	25.6 KB	476.28 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only	RAM	2.34 KB	105.27 KB	0 B
	ROM	25.6 KB	393.91 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.dut	RAM	2.34 KB	143.99 KB	0 B
	ROM	25.67 KB	541.41 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure	RAM	2.34 KB	143.96 KB	0 B
	ROM	25.66 KB	532.86 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.hello	RAM	2.34 KB	121.57 KB	0 B
	ROM	25.62 KB	491.32 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only	RAM	2.34 KB	95.1 KB	0 B
	ROM	25.61 KB	392.26 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release	RAM	2.34 KB	90.29 KB	0 B
	ROM	24.86 KB	324.27 KB	0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release	RAM	2.34 KB	105.37 KB	0 B
	ROM	24.88 KB	403.22 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo	RAM	2.07 KB	113.55 KB	0 B
	ROM	3.38 KB	398.84 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only	RAM	2.07 KB	98.62 KB	0 B
	ROM	3.37 KB	315.32 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut	RAM	2.07 KB	137.31 KB	0 B
	ROM	3.43 KB	464.69 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure	RAM	2.07 KB	137.3 KB	0 B
	ROM	3.44 KB	457.24 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello	RAM	2.07 KB	115.04 KB	0 B
	ROM	3.38 KB	414.13 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only	RAM	2.07 KB	88.71 KB	0 B
	ROM	3.39 KB	313.92 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release	RAM	2.07 KB	84.06 KB	0 B
	ROM	2.64 KB	243.68 KB	0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release	RAM	2.07 KB	98.99 KB	0 B
	ROM	2.62 KB	323.4 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo	RAM	1.16 KB	117.46 KB	0 B
	ROM	8.25 KB	403.9 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only	RAM	1.16 KB	102.69 KB	0 B
	ROM	8.25 KB	326.26 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut	RAM	1.16 KB	141.21 KB	0 B
	ROM	8.32 KB	469.75 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure	RAM	1.16 KB	141.21 KB	0 B
	ROM	8.32 KB	467.05 KB	0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello	RAM	1.16 KB	118.91 KB	0 B
	ROM	8.27 KB	418.92 KB	0 B

[RobertGalatNordic]

good job, but Sidewalk has also API for disabling BLE, I think that we should have some kind of global reference counter and do not disable the BLE stack if some other part of the application uses it

sdk-sidewalk/subsys/sal/sid_pal/src/sid_ble_adapter.c

Lines 254 to 267 in 7238295

	static sid_error_t ble_adapter_deinit(void)
	{
	LOG_DBG("Sidewalk -> BLE");
	sid_ble_conn_deinit();
	int err = bt_disable();
	if (err) {
	LOG_ERR("BT disable failed (error %d)", err);
	return SID_ERROR_GENERIC;
	}
	return SID_ERROR_NONE;
	}

update: maybe we should move ble init/deinit to sample in the mutliple adverising/connection use case?

[ktaborowski]

Thre is yet another place which modifies Bluetooth paramters utils/sidewalk_dfu/nordic_dfu.c
We shoould make sure it works correct (I tnik the CI tests will verify it, just make sure the correct suit passed). As a next step we can add Nordic DFU service as a second (third?) advertising set

[RobertGalatNordic]

Unit tests need to be reviewed. I made them green, but at this point I doubt if they test anything (or at list they does not clearly communicate what is actually tested)

[RobertGalatNordic]

This implementation does not introduce paralel SMP and Sidewalk connection, but lays a ground for such implementaiton by separating and filtering advertising and connections based on ID.

The parallel Sidewalk and SMP service will be made by separate PR, as it needs more sophisticated way of calling bt_disable to make sure that sidewalk does not disable BLE when it switches transport while SMP is working on DFU