Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strava #47

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Add strava #47

merged 2 commits into from
Jan 20, 2017

Conversation

jstoup111
Copy link

@nraboy

I've added support for Strava. This flow only gets the code from Strava and gives you the capability to handle how you want the access token from there.

See #7

Retrieving the access_token is as simple POSTing per their documentation.

curl -X POST https://www.strava.com/oauth/token
-F client_id=5
-F client_secret=7b2946535949ae70f015d696d8ac602830ece412
-F code=75e251e3ff8fff
This is safer since the clientID wouldn't be stored client side.

Updated per your comments.

@jstoup111
Copy link
Author

Is this good to go? Would like to know when a merge and release with this might be available.

@nraboy
Copy link
Owner

nraboy commented Jan 16, 2017

Thanks for reminding me!

Just to confirm, have you tested this within an app? Let me know and I'll get it merged.

Best,

@jstoup111
Copy link
Author

Yea I was running it previously, before I wiped node_modules and forgot I wasn't pointing locally anymore.

@jstoup111
Copy link
Author

Just a friendly bump. :)

@nraboy nraboy merged commit 420ac6d into nraboy:development Jan 20, 2017
@nraboy
Copy link
Owner

nraboy commented Jan 20, 2017

Sorry about taking so long. Problem with so many GitHub projects is finding the time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants