Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strava provider #46

Closed
wants to merge 2 commits into from
Closed

Conversation

jstoup111
Copy link

@nraboy

I've added support for Strava. This flow only gets the code from Strava and gives you the capability to handle how you want the access token from there.

See #7

Retrieving the access_token is as simple POSTing per their documentation.

curl -X POST https://www.strava.com/oauth/token \
    -F client_id=5 \
    -F client_secret=7b2946535949ae70f015d696d8ac602830ece412 \
    -F code=75e251e3ff8fff

This is safer since the clientID wouldn't be stored client side.

@nraboy
Copy link
Owner

nraboy commented Jan 5, 2017

Your contribution didn't pass my tests. Can you please correct the issues and try again? Also, I only accept PR on the development branch. You'll have to clone the repository, switch branches, and apply your changes.

Best,

@jstoup111 jstoup111 closed this Jan 5, 2017
@jstoup111 jstoup111 deleted the add-strava-provider branch January 5, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants