Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all analyze warnings #224

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Fix all analyze warnings #224

merged 8 commits into from
Oct 31, 2023

Conversation

kackogut
Copy link
Collaborator

Description

Fix all warnings produced by flutter analyze to make CI build successful

Checklist:

Creator

  • The target branch is dev
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

JElgar
JElgar approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@JElgar JElgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroic

@kackogut kackogut merged commit 1fadb66 into dev Oct 31, 2023
2 checks passed
@kackogut kackogut deleted the tech/fix_analysis branch October 31, 2023 20:26
JElgar added a commit that referenced this pull request Nov 12, 2023
@kackogut @JElgar
Feature/resolve conflicts (#225)
3ab6e98 
* Update secret extractor

* Fix app build

* Split release workflows

* Remove google services generation

* Fixes - launch learning resource when logged out, new filter for all tab, remove campaign description new line characters

* Fix all analyze warnings (#224)

* Fix all analyze warnings

* Regenerated pod lockfile

* Don't fail analyze on infos

* Fix analysis_options sections

* Regenerated pod lockfile

* Fix nullability issues

* Regenerated pod lockfile

* Remove unrecognized `--set-exit-if-change` from Flutter formatter

---------

Co-authored-by: kackogut <[email protected]>

* tech/update-inappwebview (#223)

* Fix iOs builds by upgrading webview version

* Regenerated pod lockfile

* Regenerated pod lockfile

---------

Co-authored-by: kackogut <[email protected]>

* Regenerated pod lockfile

---------

Co-authored-by: James Elgar <[email protected]>
Co-authored-by: kackogut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JElgar JElgar JElgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kackogut @JElgar