Use semantic tags instead of style tags #1929
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! Any CSS that needs to be updated to match? |
CendioOssman
requested changes
Jan 17, 2025
ThinLinc-Zeijlon
force-pushed
the
semantic_tags
branch
from
2a5d2d5 to
9e010dc
Compare
We aren't emphasizing important information with bold tags anywhere else, so we shouldn't do it here either.
ThinLinc-Zeijlon
force-pushed
the
semantic_tags
branch
from
9e010dc to
4f284c2
Compare
CendioOssman
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is good practice to provide styling that help indicate the importance of the presented text.