feat: add remove proxy with proxy #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Asmadek
commented
Apr 4, 2024
Asmadek
commented
- use new flow (controller model) for remove proxy
- use proxy accounts for add remove
- fix bug with sigher for add/remove/remove-pure
Current coverage reportSummary
Tests which was executed
Coverage by files (0%)
|
Jest Unit tests resultsDuration: 65.538 seconds
Outcome: Passed | Total Tests: 693 | Passed: 691 | Failed: 0
|
This was
linked to
issues
Apr 5, 2024
tuul-wq
reviewed
Apr 8, 2024
src/renderer/widgets/AddProxyModal/model/__tests__/add-proxy-model.test.ts
Outdated
Show resolved
Hide resolved
src/renderer/widgets/RemoveProxyModal/lib/submit-proxy-utils.ts
Outdated
Show resolved
Hide resolved
src/renderer/widgets/RemovePureProxyModal/model/remove-pure-proxy-model.ts
Show resolved
Hide resolved
src/renderer/widgets/WalletDetails/ui/wallets/ProxiedWalletDetails.tsx
Outdated
Show resolved
Hide resolved
tuul-wq
approved these changes
Apr 8, 2024
This was
unlinked from
issues
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.