Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove pure proxy #1605

Merged
merged 13 commits into from
Apr 2, 2024
Merged

feat: remove pure proxy #1605

merged 13 commits into from
Apr 2, 2024

Conversation

Asmadek
Copy link
Contributor

@Asmadek Asmadek commented Mar 28, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Current coverage report

Summary

Lines Statements Branches Functions
Covered: 55%
 56.66% (663/1170) 28.97% (93/321) 40.97% (134/327)

Tests which was executed

Tests Skipped Failures Errors Time
464 0 💤 0 ❌ 0 🔥 58.457s ⏱️
Coverage by files (0%) 
File% Stmts% Branch% Funcs% LinesUncovered Line #s

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

Jest Unit tests results

Generic badge

Duration: 107.63 seconds
Start: 2024-04-01 14:38:50.704 UTC
Finish: 2024-04-01 14:40:38.334 UTC
Duration: 107.63 seconds
Outcome: Passed | Total Tests: 691 | Passed: 689 | Failed: 0
Total Test Suites: 161
Total Tests: 691
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 160
Passed Tests: 689
Pending Test Suites: 1
Pending Tests: 2

@tuul-wq tuul-wq self-requested a review March 29, 2024 05:56
@Asmadek Asmadek marked this pull request as ready for review March 29, 2024 11:53
@Asmadek Asmadek linked an issue Mar 29, 2024 that may be closed by this pull request
Remove a pure proxy #1480
Closed
tuul-wq
tuul-wq reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@tuul-wq tuul-wq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

src/renderer/shared/ui/Inputs/Input/Input.tsx Outdated Show resolved Hide resolved
src/renderer/widgets/AddPureProxiedModal/model/add-pure-proxied-model.ts Show resolved Hide resolved
src/renderer/widgets/RemovePureProxyModal/model/remove-pure-proxy-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/RemovePureProxyModal/model/warning-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/RemovePureProxyModal/model/warning-model.ts Outdated Show resolved Hide resolved
src/renderer/widgets/RemovePureProxyModal/model/warning-model.ts Show resolved Hide resolved
src/renderer/widgets/RemovePureProxyModal/ui/RemovePureProxyForm.tsx Outdated Show resolved Hide resolved
src/renderer/widgets/WalletDetails/ui/components/ProxiesList.tsx Outdated Show resolved Hide resolved
@Asmadek Asmadek requested a review from tuul-wq April 1, 2024 14:38
@Asmadek Asmadek merged commit 48eeabe into dev Apr 2, 2024
4 of 5 checks passed
@Asmadek Asmadek deleted the feat/remove-pure-proxy branch April 2, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuul-wq tuul-wq tuul-wq approved these changes

Assignees

@Asmadek Asmadek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove a pure proxy
2 participants
@Asmadek @tuul-wq