feat: Acme challenge improvements based on security audit #2420
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
mikkbachmann
force-pushed
the
XRDDEV-2732
branch
from
0156bba
to
8593110
Compare
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
enelir
approved these changes
Nov 18, 2024
…so that we don't expose it needlessly; As a Developer I want to harden the way we handle use input in ACME challenges so that we don't leave a potential opening in the future refs: XRDDEV-2732, XRDDEV-2733
mikkbachmann
force-pushed
the
XRDDEV-2732
branch
from
8593110
to
7952ed3
Compare
|
Job Summary for GradleBuild and test :: BuildAndPackageWithUnitTests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a Developer I want to disable port 4000 for ACME challenges so that we don't expose it needlessly;
As a Developer I want to harden the way we handle use input in ACME challenges so that we don't leave a potential opening in the future
refs: XRDDEV-2732, XRDDEV-2733