Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): Make Hasher trait generic over input type #7138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jan 21, 2025

Makes the Hasher trait generic with type parameter T to support different input types beyond Field. This change:

  • Adds type parameter T to Hasher trait
  • Updates BuildHasher and BuildHasherDefault accordingly
  • Maintains backwards compatibility with existing Field implementations
  • Removes TODO comment about generic types

Copy link
Contributor

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing necessary trait bounds. Will review later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants