feat: add optional methods to the cache store #3747
Draft
+110
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Oct 22, 2024
flakey5
suggested changes
Oct 22, 2024
There was a problem hiding this comment.
can you add type checks for the new methods in assertCacheStore please
Line 184 in 3030506
types/cache-interceptor.d.ts
Outdated
| @@ -88,6 +92,10 @@ declare namespace CacheHandler { | |||
|
|
|||
| get isFull (): boolean | |||
|
|
|||
| getOrigins (): Promise<string[]> | |||
|
|
|||
| getRoutesByOrigin (origin: string): Promise<{ method: string, path: string }[]> | |||
There was a problem hiding this comment.
nit but would prefer if the { method: string, path: string } type was defined outside of the fn declaration so it can be referenced elsewhere if needed (incl user space)
i.e.
export interface RouteByOrigin {
method: string
path: string
}
export interface CacheStore {
getRoutesByOrigin(origin: string): Promise<RouteByOrigin[]>
// ...
}
I'm not sure about that as these methods are optional, because they are not used by the undici package. |
flakey5
approved these changes
Oct 23, 2024
|
Ci does not look green |
It fails in the main with the same error. |
|
I make it a draft for now. Not sure about the interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to add some optional methods to the cache store that might not be used by the interceptor, but are useful for managing the cache. Right now it's hard to invalidate the cache from the outside of the package, because there is no way to know what values have been cached.
Any ideas about the intercase for these methods are welcome. I'm opening it's as a draft because it's missing a docs at least.