[tuner] Clean up candidate generation code #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kuhar
commented
Nov 14, 2024
kuhar
commented
- Pass context explicitly to the parse function
- Fix mypy typing violations
- Add pyproject.toml
kuhar
requested review from
ScottTodd,
bangtianliu,
makslevental,
nithinsubbiah and
Max191
* Pass context explicitly to the parse function * Fix mypy typing violations * Add pyproject.toml Signed-off-by: Jakub Kuderski <[email protected]>
kuhar
force-pushed
the
candidate-gen-cleanup
branch
from
131da23
to
b800d1c
Compare
Signed-off-by: Jakub Kuderski <[email protected]>
Signed-off-by: Jakub Kuderski <[email protected]>
ScottTodd
approved these changes
Nov 14, 2024
Signed-off-by: Jakub Kuderski <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.