Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS as a Tier 3 platform #640

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Add iOS as a Tier 3 platform #640

merged 1 commit into from
Jul 3, 2017

Conversation

Susurrus
Copy link
Contributor

With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the libc currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).

@asomers
Copy link
Member

asomers commented Jul 1, 2017

ios isn't listed as a supported target at https://github.com/japaric/cross . Is the documentation just out of date? You should try cross building cargo for ios. If it works, then you can update cross's supported target list. If not, then I don't think we can trust cross to build nix for that platform.

Also, the build error looks ominous: error[E0463]: can't find crate for std

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 1, 2017

It isn't listed, but I'm working on the trust side of things in japaric/trust#72.

@Susurrus Susurrus force-pushed the ios_builds branch 3 times, most recently from 1710a04 to f008cc6 Compare July 3, 2017 02:02
@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

So this now works for building all 5 iOS targets. I don't think this is too controversial, as nobody's chimed in here, so I'll go ahead and merge this in a bit if someone doesn't beat me to it.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2017
640: Add iOS as a Tier 3 platform r=Susurrus

With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the `libc` currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).
@bors
Copy link
Contributor

bors bot commented Jul 3, 2017

Build failed

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

Was an intermittent failure from one of the errno tests. I think we'll need to create a new subprocess for those tests.

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2017
640: Add iOS as a Tier 3 platform r=Susurrus

With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the `libc` currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).
@bors
Copy link
Contributor

bors bot commented Jul 3, 2017

Build failed

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

test::sys::test_aio::test_aio_cancel_all() failed this most recent time. The solution might be to run these tests in separate processes or just not run the tests in QEMU.

Let's try this again...

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2017
640: Add iOS as a Tier 3 platform r=Susurrus

With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the `libc` currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).
@asomers
Copy link
Member

asomers commented Jul 3, 2017

@Susurrus I saw that test fail recently for powerpc. Which arch failed it just now?

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

@asomers powerpc-unknown-linux-gnu

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

I've definitely seen it fail before. I'm betting most of those tests need to be disabled on powerpc as well because of weird QEMU issues.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

LOL, back to test_errno_values not finishing. Have you seen that fail as well?

@asomers
Copy link
Member

asomers commented Jul 3, 2017

I haven't seen any problems with test_errno_values

@bors
Copy link
Contributor

bors bot commented Jul 3, 2017

Build failed

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

I'm going to try running tests using a single thread and see if that does anything. I can't imagine why test_errno_values stalls out as it doesn't have any looping and it's a fairly simple test. This is my first attempt to debug it.

@asomers
Copy link
Member

asomers commented Jul 3, 2017

I thought it was sufficient to put CARGO_TEST_THREADS=1 in .travis.yml. I guess we'll see.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

It wouldn't be, because cross gets rid of all environment variables but it allows a whitelist of environment variables.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

Well that worked, I'm going to move that testing commit to another branch, and we'll see if it works there.

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

And of course, now all the tests pass...

bors r+

@Susurrus
Copy link
Contributor Author

Susurrus commented Jul 3, 2017

I guess I could just merge this without relying on bors, since we're a pretty low-traffic repo, but I'll do this the "right" way here.

bors bot added a commit that referenced this pull request Jul 3, 2017
640: Add iOS as a Tier 3 platform r=Susurrus

With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the `libc` currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).
@bors
Copy link
Contributor

bors bot commented Jul 3, 2017

@bors bors bot merged commit 8809064 into nix-rust:master Jul 3, 2017
@Susurrus Susurrus deleted the ios_builds branch July 13, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants