-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS as a Tier 3 platform #640
Conversation
ios isn't listed as a supported target at https://github.com/japaric/cross . Is the documentation just out of date? You should try cross building cargo for ios. If it works, then you can update cross's supported target list. If not, then I don't think we can trust cross to build nix for that platform. Also, the build error looks ominous: |
It isn't listed, but I'm working on the |
1710a04
to
f008cc6
Compare
So this now works for building all 5 iOS targets. I don't think this is too controversial, as nobody's chimed in here, so I'll go ahead and merge this in a bit if someone doesn't beat me to it. |
bors r+ |
Build failed |
Was an intermittent failure from one of the bors r+ |
Build failed |
Let's try this again... bors r+ |
@Susurrus I saw that test fail recently for powerpc. Which arch failed it just now? |
@asomers |
I've definitely seen it fail before. I'm betting most of those tests need to be disabled on powerpc as well because of weird QEMU issues. |
LOL, back to |
I haven't seen any problems with test_errno_values |
Build failed |
I'm going to try running tests using a single thread and see if that does anything. I can't imagine why |
I thought it was sufficient to put |
It wouldn't be, because |
Well that worked, I'm going to move that testing commit to another branch, and we'll see if it works there. |
And of course, now all the tests pass... bors r+ |
I guess I could just merge this without relying on bors, since we're a pretty low-traffic repo, but I'll do this the "right" way here. |
Build succeeded |
With this and #639, then we have at least basic testing recurring for all mobile platforms (note that this is more than the
libc
currently tests, so we may have trouble moving the non-x86 targets to Tier2 until that happens).