clippy cleanup: needless as_bytes() in tests test_sendfile_dragonfly/test_recverr
#2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Nov 11, 2024
| @@ -2914,7 +2914,7 @@ mod linux_errqueue { | |||
| ) | |||
| .unwrap(); | |||
| // The sent message / destination associated with the error is returned: | |||
| assert_eq!(msg.bytes, MESSAGE_CONTENTS.as_bytes().len()); | |||
There was a problem hiding this comment.
Could you please tell me what error you got before this PR, looks like they are equivalent and both return the length in bytes 🤔
There was a problem hiding this comment.
it is pedantism
error: needless call to `as_bytes()`
--> test/test_sendfile.rs:146:40
|
146 | assert_eq!(bytes_written as usize, expected_string.as_bytes().len());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `expected_string.len()`same reason for both.
There was a problem hiding this comment.
In the commit message, you should name what error you're fixing.
There was a problem hiding this comment.
This is a clippy cleanup, not a fix, so let's update the PR title a bit since it will be used as the commit message
SteveLauC
changed the title
test_sendfile_dragonfly/test_recverr
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
remove as_bytes().len() calls when we can call len() on strings. ``` error: needless call to `as_bytes()` ```
|
oh you did already :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.