Use TryFrom for TimeSpec/Duration conversions which may underflow/overflow #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their underlying types are not congruent and therefor "lossy" conversions with usually unexpected behavior result from it. Let's make this explicit by switching from From conversions to TryFrom. The error types used there are quite spartan. Is there a need for more detailed reporting?
sirhcel
force-pushed
the
timespec-try-from-duration
branch
from
62a9227
to
65b0fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
FromtoTryFromfor conversions betweenTimeSpecandDurationwhich may underflow or overflowFromandTryFromcan not co-exist and so adding the latter and deprecating the former does not seem feasible and it looks like we are left with a breaking change hereTryFrom. The underlying integer conversions return aTryFromIntErrorwhich informs that the conversion has failed but gives no specific reason.Checklist:
CONTRIBUTING.md