Rename Flags EventFlag and MemFdCreateFlag #2476
Merged
+22
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Existing changes look good, thanks!
Though you need to address the CI failures, i.e., rename the usages on other platforms as well.
And can we have something like this to help users migrate:
#[deprecated(since = "0.30.0", note = "Use `EvFlags instead`")]
pub type EventFlag = EvFlags;
|
Also, a changelog entry is needed, see this on how to add one. |
howjmay
force-pushed
the
rename-flag
branch
3 times, most recently
from
eb300f1
to
4be7d73
Compare
SteveLauC
reviewed
Nov 16, 2024
| @@ -11,7 +11,7 @@ fn test_struct_kevent() { | |||
| let actual = KEvent::new( | |||
| 0xdead_beef, | |||
| EventFilter::EVFILT_READ, | |||
There was a problem hiding this comment.
@asomers, any idea what we should do to things like this enum EventFilter?
use nix::sys::event::{EvFlags, EventFilter};
Honestly, it feels weird to me when putting them together 🥲, one aims to be short, typical C-style, one aims to be self-explanatory.
There was a problem hiding this comment.
If does seem odd now. I think they'll need hard to remember like this. We should probably make the two names more consistent.
|
thank you too |
|
Let's merge this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #317
What does this PR do
Rename Flags
Checklist:
CONTRIBUTING.md