Rename fanotify OFlags to EventFFlags

nix-rust · Nov 20, 2023 · 44feea8 · 44feea8
1 parent db46b2e
commit 44feea8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 6 deletions.
diff --git a/src/fcntl.rs b/src/fcntl.rs
@@ -64,7 +64,11 @@ libc_bitflags! {
     }
 }
 
-#[cfg(any(feature = "fs", feature = "term"))]
+#[cfg(any(
+    feature = "fs",
+    feature = "term",
+    all(feature = "fanotify", target_os = "linux")
+))]
 libc_bitflags!(
     /// Configuration options for opened files.
     #[cfg_attr(docsrs, doc(cfg(any(feature = "fs", feature = "term"))))]

diff --git a/src/sys/fanotify.rs b/src/sys/fanotify.rs
@@ -12,6 +12,7 @@
 
 use crate::{NixPath, Result};
 use crate::errno::Errno;
+use crate::fcntl::OFlag;
 use crate::unistd::{read, write};
 use std::os::unix::io::{AsFd, AsRawFd, BorrowedFd, FromRawFd, OwnedFd, RawFd};
 use std::mem::{MaybeUninit, size_of};
@@ -102,7 +103,7 @@ libc_bitflags! {
 
 libc_bitflags! {
     /// File status flags for fanotify events file descriptors.
-    pub struct OFlags: libc::c_uint {
+    pub struct EventFFlags: libc::c_uint {
         /// Read only access.
         O_RDONLY as libc::c_uint;
         /// Write only access.
@@ -126,6 +127,20 @@ libc_bitflags! {
     }
 }
 
+impl TryFrom<OFlag> for EventFFlags {
+    type Error = Errno;
+
+    fn try_from(o_flag: OFlag) -> Result<Self> {
+        EventFFlags::from_bits(o_flag.bits() as u32).ok_or(Errno::EINVAL)
+    }
+}
+
+impl From<EventFFlags> for OFlag {
+    fn from(event_f_flags: EventFFlags) -> Self {
+        OFlag::from_bits_retain(event_f_flags.bits() as i32)
+    }
+}
+
 libc_bitflags! {
     /// Configuration options for [`fanotify_mark`](fn.fanotify_mark.html).
     pub struct MarkFlags: libc::c_uint {
@@ -223,7 +238,7 @@ impl Fanotify {
     /// Returns a Result containing a Fanotify instance.
     ///
     /// For more information, see [fanotify_init(2)](https://man7.org/linux/man-pages/man7/fanotify_init.2.html).
-    pub fn init(flags: InitFlags, event_f_flags: OFlags) -> Result<Fanotify> {
+    pub fn init(flags: InitFlags, event_f_flags: EventFFlags) -> Result<Fanotify> {
         let res = Errno::result(unsafe {
             libc::fanotify_init(flags.bits(), event_f_flags.bits())
         });

diff --git a/test/sys/test_fanotify.rs b/test/sys/test_fanotify.rs
@@ -1,6 +1,6 @@
 use crate::*;
 use nix::sys::fanotify::{
-    Fanotify, FanotifyResponse, InitFlags, MarkFlags, MaskFlags, OFlags,
+    EventFFlags, Fanotify, FanotifyResponse, InitFlags, MarkFlags, MaskFlags,
     Response,
 };
 use std::fs::{read_link, File, OpenOptions};
@@ -20,7 +20,8 @@ pub fn test_fanotify() {
 
 fn test_fanotify_notifications() {
     let group =
-        Fanotify::init(InitFlags::FAN_CLASS_NOTIF, OFlags::O_RDONLY).unwrap();
+        Fanotify::init(InitFlags::FAN_CLASS_NOTIF, EventFFlags::O_RDONLY)
+            .unwrap();
     let tempdir = tempfile::tempdir().unwrap();
 
     group
@@ -88,7 +89,8 @@ fn test_fanotify_notifications() {
 
 fn test_fanotify_responses() {
     let group =
-        Fanotify::init(InitFlags::FAN_CLASS_CONTENT, OFlags::O_RDONLY).unwrap();
+        Fanotify::init(InitFlags::FAN_CLASS_CONTENT, EventFFlags::O_RDONLY)
+            .unwrap();
     let tempdir = tempfile::tempdir().unwrap();
 
     group