-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add indentation options to kate #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my two small comments. Looks good to me otherwise assuming you have tested that the module works (I don't really use kate so I can't really test)
fixed |
ffd3787
to
6770e93
Compare
I added an enable option (which is in general good practice) and assigned |
@magnouvean we can merge this imo |
This is the first contribution to #87 .
It allows users to configure the way kate handles indentation.
Reasoning about decisions:
I decided to put all options into
config.programs.kate.editor
. Theeditor
option should contain all options that act on configuration into the rectangle where users type text in (as opposed to: the console, theproject
tab, the menus and sidebards).Known limitations:
kate
needs to be restart after switching the configuration. I could not figure out how to makekate
do a hot reload on the changedkaterc
.Do you want me to put all changes into a single MR (leaving this one open), or do you prefer each change to be its own PR?