Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: add new quotes and author #64

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Refactor: add new quotes and author #64

merged 6 commits into from
Jan 30, 2024

Conversation

sumanjha108155
Copy link
Collaborator

Description

this PR adds new quotes and author


Issue

Copy link
Owner

@nirajgiriXD nirajgiriXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the quotes mentioned here are already present in the data.json. Please remove those quotes.

public/quotes.json Outdated Show resolved Hide resolved
public/quotes.json Outdated Show resolved Hide resolved
public/quotes.json Outdated Show resolved Hide resolved
Comment on lines 3643 to 3647
{
"quote": "The only way to do great work is to love what you do.",
"author": "Steve Jobs",
"tags": ["wisdom"]
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"quote": "The only way to do great work is to love what you do.",
"author": "Steve Jobs",
"tags": ["wisdom"]
},

Remove as it is repeated.

public/quotes.json Outdated Show resolved Hide resolved
public/quotes.json Outdated Show resolved Hide resolved
@nirajgiriXD nirajgiriXD merged commit 60a5028 into main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants