changing template formatting when value (or default) is False #561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 77.13% 77.09% -0.04%
==========================================
Files 20 20
Lines 4316 4322 +6
Branches 1212 1215 +3
==========================================
+ Hits 3329 3332 +3
- Misses 799 802 +3
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ld function to get a specific field from a spec
|
@yibeichan - this is the fix for the template, I was trying this on the example of |
|
@djarecka thank you! so I create a local branch for |
| @@ -1170,6 +1172,8 @@ def test_shell_cmd_inputs_template_6(): | |||
| executable="executable", input_spec=my_input_spec, inpA="inpA", outA=False | |||
| ) | |||
| assert shelly.cmdline == "executable inpA" | |||
| # checking of the command is the same | |||
| assert shelly.cmdline == "executable inpA" | |||
There was a problem hiding this comment.
@djarecka isn't line 1176 the same as the line 1174? shouldn't we add something like shelly.run() between 1174 and 1176?
There was a problem hiding this comment.
actually I realized that the run wasn't an issue when we were checking this last week, simply repeating cmdline was giving a new result, it was a bug... That's why I added this to the test...
|
thanks, I will check your tests |
Types of changes
Summary
when output use template to create the output path and value is
Falsethe field should not be used in the cmdline, it was inconsistentChecklist