Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcm2niix - Do consider exit 1 to be an error #3594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dcm2niix - Do consider exit 1 to be an error #3594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions nipype/interfaces/dcm2nii.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,7 @@
return super()._format_arg(opt, spec, val)

def _run_interface(self, runtime):
# may use return code 1 despite conversion
runtime = super()._run_interface(runtime, correct_return_codes=(0, 1))
runtime = super()._run_interface(runtime)

Check warning on line 449 in nipype/interfaces/dcm2nii.py

View check run for this annotation

Codecov / codecov/patch

nipype/interfaces/dcm2nii.py#L449 

Added line #L449 was not covered by tests
self._parse_files(self._parse_stdout(runtime.stdout))
return runtime

Expand Down