Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Ripple effect #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved Ripple effect #235

wants to merge 1 commit into from

Conversation

onmax
Copy link
Member

@onmax onmax commented Nov 25, 2024

  • Now the distance between the rings is constant
  • Made the SVG smaller
  • Simpler CSS

@onmax onmax requested a review from mraveux November 25, 2024 08:42
@onmax onmax force-pushed the onmax/ripple-staking-animation branch from 4b7362c to e210c2b Compare November 25, 2024 08:43
@sisou
Copy link
Member

sisou commented Jan 13, 2025

@onmax Is this still relevant? I don't think we still have the ripple effect on the icon, do we?

@onmax
Copy link
Member Author

onmax commented Jan 13, 2025

I am not sure if this still relevant

We are still using it in some components https://github.com/search?q=repo%3Animiq%2Fwallet%20HeroIcon&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraveux mraveux Awaiting requested review from mraveux

Assignees

@mraveux mraveux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onmax @sisou @mraveux