Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json PR for FRENCH NIMIQ VALIDATOR #1 & #2 by Ju #75

Merged
merged 14 commits into from
Dec 27, 2024

Conversation

Julien59247787
Copy link
Contributor

Hi,

Just a little PR for the validation of my validators informations

Thank in advance and big thanks for all your great work on NIMIQ !

Ju

@Albermonte
Copy link
Member

The website needs to be a plubic reachable website, where your pool info is shown

@onmax
Copy link
Member

onmax commented Dec 6, 2024

Hello. We have decided not to allow white background in the logo because it will look broken.

Here are some alternatives:

  1. Use a background with more contrast
  2. Remove the hexagon shape, as it essentially only cuts off a small part of the computer.

We would recommend the first, as we may need the hexagon shape in the future.

Please let me know if there is any convenient

Thanks for your understanding

@Julien59247787
Copy link
Contributor Author

Julien59247787 commented Dec 6, 2024 via email

@Julien59247787
Copy link
Contributor Author

Julien59247787 commented Dec 6, 2024 via email

@onmax
Copy link
Member

onmax commented Dec 7, 2024

Could you tell me or give me the link to the documentation to help me build my own rewards management script, please? I can’t find an official one anywhere.

We do not offer this kind of scripts at the moment. But feel free to join our validators' Telegram group to seek help in this reward from other pools.

If you are interested I can send you the link.

@Albermonte
Copy link
Member

If you dont have a public website, remove it from the json, thanks.

temporary deletion of website url during construction phase
temporary deletion of website url during construction phase
Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/nimiq/validators-api/nimiq-albatross-policy@75
npm i https://pkg.pr.new/nimiq/validators-api/nimiq-rewards-calculator@75
npm i https://pkg.pr.new/nimiq/validators-api/nimiq-validators-trustscore@75
npm i https://pkg.pr.new/nimiq/validators-api/nimiq-supply-calculator@75

commit: 601f0f4

@Albermonte
Copy link
Member

Check lint pls

@onmax
Copy link
Member

onmax commented Dec 13, 2024

LGTM, @NimiqToolbox please let us know when we can merge it :)

Thanks

@Julien59247787
Copy link
Contributor Author

Julien59247787 commented Dec 15, 2024 via email

@Julien59247787
Copy link
Contributor Author

hey 👋

Is it OK to merge now ?

thanks

Happy Christmas ! 🎄 🎅

@Julien59247787 Julien59247787 changed the title add FRENCH NIMIQ VALIDATOR by Ju #1 & #2 Json PR for FRENCH NIMIQ VALIDATOR #1 & #2 by Ju Dec 23, 2024
@Julien59247787
Copy link
Contributor Author

Julien59247787 commented Dec 26, 2024

hey @Albermonte, @onmax , @NimiqToolbox 👋
Could you do something to speed up the "NimiqToolbox" review plz ?

Thank you very much

Ju

@Albermonte Albermonte merged commit 5a62ba1 into nimiq:main Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants