Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(garudapool): update pool details json #73

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

MelvishNiz
Copy link
Contributor

My pool allows users to choose between restake or direct payouts. What should I set as the value for payoutType: restake or direct?

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/nimiq/validators-api/nimiq-rewards-calculator@73
npm i https://pkg.pr.new/nimiq/validators-api/nimiq-supply-calculator@73
npm i https://pkg.pr.new/nimiq/validators-api/nimiq-validators-trustscore@73

commit: f4a7628

@onmax
Copy link
Member

onmax commented Dec 3, 2024

My pool allows users to choose between restake or direct payouts. What should I set as the value for payoutType: restake or direct?

Hello. We may introduce a new value for payoutType for cases like this, but for now I would recommend using the default value that you have for payoutType and updating the description to let users know now that your pool is flexible.

I know this is not the best, but we are working on it...

@MelvishNiz
Copy link
Contributor Author

okay then i updated my description. thanks

@MelvishNiz
Copy link
Contributor Author

can we merge to main ?

@onmax
Copy link
Member

onmax commented Dec 5, 2024

Hey hello.

Sorry, the current process of verifying and validating the information you submit is quite slow and not very transparent.

If anything is off I will let you know in the PR.

Sorry about the inconvenience but we are working in a better approach.

Thanks for your patience

@MelvishNiz
Copy link
Contributor Author

In my commit, I only updated my pool details. Could you please let me know what process is currently underway?

Hey hello.

Sorry, the current process of verifying and validating the information you submit is quite slow and not very transparent.

If anything is off I will let you know in the PR.

Sorry about the inconvenience but we are working in a better approach.

Thanks for your patience

@onmax
Copy link
Member

onmax commented Dec 5, 2024

We need to verify that website is not malicious and the process can take a day or two.

@onmax onmax merged commit bbc2333 into nimiq:main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants