Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR makes
Coin
serialize to a varint in transactions and accounts, both over the wire and their internal representations (history store).Reasoning
No transaction will likely ever make use of the full u64 range for its
value
, and especially not forfee
. So most zero bytes for Coins in most transactions are wasted. This is especially true for signaling transactions, which have 16 zero-bytes to represent 0 value and (mostly) 0 fee. This PR reduces them to two zero bytes.Drawbacks
Exceptions
There are two exceptions for backwards-compatibility with PoW transactions:
fixint::be
tx.serialize_content()
serializesvalue
andfee
as before withfixint::be
Pull request checklist
clippy
andrustfmt
warnings.