Add Device Label (#1)

[ryan-rowland]

Pull request checklist

• All tests pass. Demo project builds and runs.
• I have resolved any merge conflicts.

What's in this pull request?

Uses --extra-data flag or extraData config option to set deviceLabel in the case of connecting to a mining pool (where before it was discarded until reverting to solo mining).

See:
nimiq/mining-pool#12
nimiq-network/developer-reference#23

[ryan-rowland]

Failures look like random timeouts on 2 of the suites.

[mar-v-in]

Extra data is not intended to be the device name when solo mining, so it shouldn't magically get this meaning when mining for a pool. I'd prefer to just make it a separate setting in the config.

[mar-v-in]

This thing should also be signed somehow, else everyone that knows your address and device id (both may become public through the block extra data) can rename your devices.

[codecov]

Codecov Report

Merging #395 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   71.49%   71.45%   -0.05%     
==========================================
  Files         188      188              
  Lines       11710    11711       +1     
==========================================
- Hits         8372     8368       -4     
- Misses       3338     3343       +5

Impacted Files	Coverage Δ
src/main/generic/miner/SmartPoolMiner.js	20% <0%> (ø)	⬆️
src/main/generic/miner/BasePoolMiner.js	4.71% <0%> (-0.05%)	⬇️
src/main/generic/consensus/InvRequestManager.js	72.22% <0%> (-11.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97efc1a...ce18688. Read the comment docs.

[ryan-rowland]

@mar-v-in Originally, I had this as --device-label but reverted to --extra-data since I believe that's what the existing pools have been doing. I'm +1 for --device-label and pool.deviceLabel in config, if that's the route we want to go. 👍

As for signing: couldn't a malicious actor that knows both your deviceId and address already get you repeatedly banned from the pool agent by connecting at the same time as you and submitting duplicate shares? That would seem more serious than renaming the device.

[mar-v-in]

The reference pool implementation does banning by ip address, not device id.

[ryan-rowland]

Interesting -- I've been banned when connecting to a pool server with images behind different IPs, but that shared a peer-key folder due to neglecting to remove it when creating the image. But perhaps that's not due to the device ID?

[ryan-rowland]

See #401