Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#74] Update Node #75

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[#74] Update Node #75

wants to merge 2 commits into from

Conversation

malparty
Copy link
Member

@malparty malparty commented Jan 16, 2025

What happened 👀

  • Use Node 22
  • Update some dependencies
  • Resolved vulnerabilities from dependencies

Insight 📝

I'm not sure how to "test" these versions on my project, without publishing the npm package first... So if you know, let me know so I can test before we merge :harold:

Proof Of Work 📹

Before After
image image

@malparty malparty self-assigned this Jan 16, 2025
@malparty malparty marked this pull request as ready for review January 16, 2025 08:11
@malparty malparty requested review from carryall and a team as code owners January 16, 2025 08:11
@jtotty
Copy link

jtotty commented Jan 17, 2025

@malparty Just throwing an idea here: you can try using npm-link to test the packages locally in a repository that is dependent on them before publishing. I'm just quickly checking if it actually works.

https://docs.npmjs.com/cli/v9/commands/npm-link

@jtotty
Copy link

jtotty commented Jan 17, 2025

@malparty There's two ways you can do this locally with npm-link or npm-pack. While this requires manual testing and isn't the most reliable approach, it's an option.

npm-link
Creates a symlink to the package.
https://docs.npmjs.com/cli/v9/commands/npm-link

  1. In the individual package directory run npm link.
  2. cd into the root directory of a project and make sure you are using the correct nodejs version. Note: If you are using a version manager like nvm or asdf it won't use the symlinked package if there is a node version mismatch. It will install the published package specified in package.json as standard.
  3. Delete the node_modules folder
  4. Run npm link @nimblehq/eslint-config-nimble-core - this runs npm install and uses the symlinked package.

To unlink run npm unlink --no-save @nimblehq/eslint-config-nimble-core

npm-pack
Create a tarball from a package
https://docs.npmjs.com/cli/v9/commands/npm-pack

  1. In the individual package directory run npm pack --pack-destination <filepath>
  2. Update the package.json in the project to use the tarball. E.g. "@nimblehq/eslint-config-nimble-core": "file:~/temp_npm_pack/nimblehq-eslint-config-nimble-core-2.8.2.tgz"
  3. Delete the node_modules folder
  4. Run npm install
Screenshot 2025-01-17 at 14 58 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Node 22
2 participants