Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes packed trees IC #24377

Open
wants to merge 11 commits into
base: devel
Choose a base branch
from
Open

removes packed trees IC #24377

wants to merge 11 commits into from

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Oct 28, 2024 •
edited
Loading

  • remove PackedItemId
  • remove ModuleIter

@ringabout ringabout changed the title test removing Packed IC test removing packed trees IC Oct 28, 2024
@ringabout ringabout changed the title test removing packed trees IC removes packed trees IC Oct 30, 2024
@ringabout ringabout marked this pull request as ready for review October 31, 2024 11:37
ringabout
ringabout commented Oct 31, 2024
View reviewed changes
compiler/ast.nim Outdated Show resolved Hide resolved
@Araq
Copy link
Member

Araq commented Nov 1, 2024

Keep the rememberExpansion logic somehow, the new IC implementation requires it too.

@ringabout
Copy link
Member Author

Do I need to store expandedSym somewhere or just keep an empty function body in storeExpansion?

@Araq
Copy link
Member

Araq commented Nov 1, 2024

I don't know :-)

@ringabout ringabout mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq