refactoring dependency injection to arrays instead of objects

nikolovlazar · Oct 30, 2024 · e5b312d · e5b312d
1 parent 62276da
commit e5b312d
Show file tree

Hide file tree

Showing 17 changed files with 132 additions and 184 deletions.
diff --git a/di/modules/authentication.module.ts b/di/modules/authentication.module.ts
@@ -25,23 +25,23 @@ export function registerAuthenticationModule(container: Container) {
 
   container
     .bind(DI_SYMBOLS.ISignInController)
-    .toHigherOrderFunction(signInController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      signInUseCase: DI_SYMBOLS.ISignInUseCase,
-    });
+    .toHigherOrderFunction(signInController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ISignInUseCase,
+    ]);
 
   container
     .bind(DI_SYMBOLS.ISignOutController)
-    .toHigherOrderFunction(signOutController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-      signOutUseCase: DI_SYMBOLS.ISignOutUseCase,
-    });
+    .toHigherOrderFunction(signOutController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IAuthenticationService,
+      DI_SYMBOLS.ISignOutUseCase,
+    ]);
 
   container
     .bind(DI_SYMBOLS.ISignUpController)
-    .toHigherOrderFunction(signUpController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      signUpUseCase: DI_SYMBOLS.ISignUpUseCase,
-    });
+    .toHigherOrderFunction(signUpController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ISignUpUseCase,
+    ]);
 }
diff --git a/di/modules/todos.module.ts b/di/modules/todos.module.ts
@@ -29,64 +29,64 @@ export function registerTodosModule(container: Container) {
 
   container
     .bind(DI_SYMBOLS.ICreateTodoUseCase)
-    .toHigherOrderFunction(createTodoUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      todosRepository: DI_SYMBOLS.ITodosRepository,
-    });
+    .toHigherOrderFunction(createTodoUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ITodosRepository,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IDeleteTodoUseCase)
-    .toHigherOrderFunction(deleteTodoUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      todosRepository: DI_SYMBOLS.ITodosRepository,
-    });
+    .toHigherOrderFunction(deleteTodoUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ITodosRepository,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IGetTodosForUserUseCase)
-    .toHigherOrderFunction(getTodosForUserUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      todosRepository: DI_SYMBOLS.ITodosRepository,
-    });
+    .toHigherOrderFunction(getTodosForUserUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ITodosRepository,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IToggleTodoUseCase)
-    .toHigherOrderFunction(toggleTodoUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      todosRepository: DI_SYMBOLS.ITodosRepository,
-    });
+    .toHigherOrderFunction(toggleTodoUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.ITodosRepository,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IBulkUpdateController)
-    .toHigherOrderFunction(bulkUpdateController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-      transactionManagerService: DI_SYMBOLS.ITransactionManagerService,
-      toggleTodoUseCase: DI_SYMBOLS.IToggleTodoUseCase,
-      deleteTodoUseCase: DI_SYMBOLS.IDeleteTodoUseCase,
-    });
+    .toHigherOrderFunction(bulkUpdateController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IAuthenticationService,
+      DI_SYMBOLS.ITransactionManagerService,
+      DI_SYMBOLS.IToggleTodoUseCase,
+      DI_SYMBOLS.IDeleteTodoUseCase,
+    ]);
 
   container
     .bind(DI_SYMBOLS.ICreateTodoController)
-    .toHigherOrderFunction(createTodoController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-      transactionManagerService: DI_SYMBOLS.ITransactionManagerService,
-      createTodoUseCase: DI_SYMBOLS.ICreateTodoUseCase,
-    });
+    .toHigherOrderFunction(createTodoController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IAuthenticationService,
+      DI_SYMBOLS.ITransactionManagerService,
+      DI_SYMBOLS.ICreateTodoUseCase,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IGetTodosForUserController)
-    .toHigherOrderFunction(getTodosForUserController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      getTodosForUserUseCase: DI_SYMBOLS.IGetTodosForUserUseCase,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-    });
+    .toHigherOrderFunction(getTodosForUserController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IGetTodosForUserUseCase,
+      DI_SYMBOLS.IAuthenticationService,
+    ]);
 
   container
     .bind(DI_SYMBOLS.IToggleTodoController)
-    .toHigherOrderFunction(toggleTodoController, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      toggleTodoUseCase: DI_SYMBOLS.IToggleTodoUseCase,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-    });
+    .toHigherOrderFunction(toggleTodoController, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IToggleTodoUseCase,
+      DI_SYMBOLS.IAuthenticationService,
+    ]);
 }
diff --git a/di/modules/users.module.ts b/di/modules/users.module.ts
@@ -23,24 +23,24 @@ export function registerUsersModule(container: Container) {
 
   container
     .bind(DI_SYMBOLS.ISignInUseCase)
-    .toHigherOrderFunction(signInUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-      usersRepository: DI_SYMBOLS.IUsersRepository,
-    });
+    .toHigherOrderFunction(signInUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IUsersRepository,
+      DI_SYMBOLS.IAuthenticationService,
+    ]);
 
   container
     .bind(DI_SYMBOLS.ISignOutUseCase)
-    .toHigherOrderFunction(signOutUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-    });
+    .toHigherOrderFunction(signOutUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IAuthenticationService,
+    ]);
 
   container
     .bind(DI_SYMBOLS.ISignUpUseCase)
-    .toHigherOrderFunction(signUpUseCase, {
-      instrumentationService: DI_SYMBOLS.IInstrumentationService,
-      authenticationService: DI_SYMBOLS.IAuthenticationService,
-      usersRepository: DI_SYMBOLS.IUsersRepository,
-    });
+    .toHigherOrderFunction(signUpUseCase, [
+      DI_SYMBOLS.IInstrumentationService,
+      DI_SYMBOLS.IAuthenticationService,
+      DI_SYMBOLS.IUsersRepository,
+    ]);
 }
diff --git a/src/application/use-cases/auth/sign-in.use-case.ts b/src/application/use-cases/auth/sign-in.use-case.ts
@@ -10,15 +10,11 @@ import type { IAuthenticationService } from '@/src/application/services/authenti
 export type ISignInUseCase = ReturnType<typeof signInUseCase>;
 
 export const signInUseCase =
-  ({
-    instrumentationService,
-    usersRepository,
-    authenticationService,
-  }: {
-    instrumentationService: IInstrumentationService;
-    usersRepository: IUsersRepository;
-    authenticationService: IAuthenticationService;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    usersRepository: IUsersRepository,
+    authenticationService: IAuthenticationService
+  ) =>
   (input: {
     username: string;
     password: string;

diff --git a/src/application/use-cases/auth/sign-out.use-case.ts b/src/application/use-cases/auth/sign-out.use-case.ts
@@ -5,13 +5,10 @@ import type { IAuthenticationService } from '@/src/application/services/authenti
 export type ISignOutUseCase = ReturnType<typeof signOutUseCase>;
 
 export const signOutUseCase =
-  ({
-    instrumentationService,
-    authenticationService,
-  }: {
-    instrumentationService: IInstrumentationService;
-    authenticationService: IAuthenticationService;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    authenticationService: IAuthenticationService
+  ) =>
   (sessionId: string): Promise<{ blankCookie: Cookie }> => {
     return instrumentationService.startSpan(
       { name: 'signOut Use Case', op: 'function' },

diff --git a/src/application/use-cases/auth/sign-up.use-case.ts b/src/application/use-cases/auth/sign-up.use-case.ts
@@ -12,15 +12,11 @@ import { PASSWORD_SALT_ROUNDS } from '@/config';
 export type ISignUpUseCase = ReturnType<typeof signUpUseCase>;
 
 export const signUpUseCase =
-  ({
-    instrumentationService,
-    authenticationService,
-    usersRepository,
-  }: {
-    instrumentationService: IInstrumentationService;
-    authenticationService: IAuthenticationService;
-    usersRepository: IUsersRepository;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    authenticationService: IAuthenticationService,
+    usersRepository: IUsersRepository
+  ) =>
   (input: {
     username: string;
     password: string;

diff --git a/src/application/use-cases/todos/create-todo.use-case.ts b/src/application/use-cases/todos/create-todo.use-case.ts
@@ -6,13 +6,10 @@ import type { ITodosRepository } from '@/src/application/repositories/todos.repo
 export type ICreateTodoUseCase = ReturnType<typeof createTodoUseCase>;
 
 export const createTodoUseCase =
-  ({
-    instrumentationService,
-    todosRepository,
-  }: {
-    instrumentationService: IInstrumentationService;
-    todosRepository: ITodosRepository;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    todosRepository: ITodosRepository
+  ) =>
   (
     input: {
       todo: string;

diff --git a/src/application/use-cases/todos/delete-todo.use-case.ts b/src/application/use-cases/todos/delete-todo.use-case.ts
@@ -8,13 +8,10 @@ import type { ITodosRepository } from '@/src/application/repositories/todos.repo
 export type IDeleteTodoUseCase = ReturnType<typeof deleteTodoUseCase>;
 
 export const deleteTodoUseCase =
-  ({
-    instrumentationService,
-    todosRepository,
-  }: {
-    instrumentationService: IInstrumentationService;
-    todosRepository: ITodosRepository;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    todosRepository: ITodosRepository
+  ) =>
   (
     input: {
       todoId: number;

diff --git a/src/application/use-cases/todos/get-todos-for-user.use-case.ts b/src/application/use-cases/todos/get-todos-for-user.use-case.ts
@@ -5,13 +5,10 @@ import type { ITodosRepository } from '@/src/application/repositories/todos.repo
 export type IGetTodosForUserUseCase = ReturnType<typeof getTodosForUserUseCase>;
 
 export const getTodosForUserUseCase =
-  ({
-    instrumentationService,
-    todosRepository,
-  }: {
-    instrumentationService: IInstrumentationService;
-    todosRepository: ITodosRepository;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    todosRepository: ITodosRepository
+  ) =>
   (userId: string): Promise<Todo[]> => {
     return instrumentationService.startSpan(
       { name: 'getTodosForUser UseCase', op: 'function' },

diff --git a/src/application/use-cases/todos/toggle-todo.use-case.ts b/src/application/use-cases/todos/toggle-todo.use-case.ts
@@ -8,13 +8,10 @@ import type { ITodosRepository } from '@/src/application/repositories/todos.repo
 export type IToggleTodoUseCase = ReturnType<typeof toggleTodoUseCase>;
 
 export const toggleTodoUseCase =
-  ({
-    instrumentationService,
-    todosRepository,
-  }: {
-    instrumentationService: IInstrumentationService;
-    todosRepository: ITodosRepository;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    todosRepository: ITodosRepository
+  ) =>
   (
     input: {
       todoId: number;

diff --git a/src/interface-adapters/controllers/auth/sign-in.controller.ts b/src/interface-adapters/controllers/auth/sign-in.controller.ts
@@ -13,13 +13,10 @@ const inputSchema = z.object({
 export type ISignInController = ReturnType<typeof signInController>;
 
 export const signInController =
-  ({
-    instrumentationService,
-    signInUseCase,
-  }: {
-    instrumentationService: IInstrumentationService;
-    signInUseCase: ISignInUseCase;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    signInUseCase: ISignInUseCase
+  ) =>
   async (input: Partial<z.infer<typeof inputSchema>>): Promise<Cookie> => {
     return await instrumentationService.startSpan(
       { name: 'signIn Controller' },

diff --git a/src/interface-adapters/controllers/auth/sign-out.controller.ts b/src/interface-adapters/controllers/auth/sign-out.controller.ts
@@ -7,15 +7,11 @@ import { IAuthenticationService } from '@/src/application/services/authenticatio
 export type ISignOutController = ReturnType<typeof signOutController>;
 
 export const signOutController =
-  ({
-    instrumentationService,
-    authenticationService,
-    signOutUseCase,
-  }: {
-    instrumentationService: IInstrumentationService;
-    authenticationService: IAuthenticationService;
-    signOutUseCase: ISignOutUseCase;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    authenticationService: IAuthenticationService,
+    signOutUseCase: ISignOutUseCase
+  ) =>
   async (sessionId: string | undefined): Promise<Cookie> => {
     return await instrumentationService.startSpan(
       { name: 'signOut Controller' },

diff --git a/src/interface-adapters/controllers/auth/sign-up.controller.ts b/src/interface-adapters/controllers/auth/sign-up.controller.ts
@@ -28,13 +28,10 @@ const inputSchema = z
 export type ISignUpController = ReturnType<typeof signUpController>;
 
 export const signUpController =
-  ({
-    instrumentationService,
-    signUpUseCase,
-  }: {
-    instrumentationService: IInstrumentationService;
-    signUpUseCase: ISignUpUseCase;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    signUpUseCase: ISignUpUseCase
+  ) =>
   async (
     input: Partial<z.infer<typeof inputSchema>>
   ): Promise<ReturnType<typeof signUpUseCase>> => {

diff --git a/src/interface-adapters/controllers/todos/bulk-update.controller.ts b/src/interface-adapters/controllers/todos/bulk-update.controller.ts
@@ -16,19 +16,13 @@ const inputSchema = z.object({
 export type IBulkUpdateController = ReturnType<typeof bulkUpdateController>;
 
 export const bulkUpdateController =
-  ({
-    instrumentationService,
-    authenticationService,
-    transactionManagerService,
-    toggleTodoUseCase,
-    deleteTodoUseCase,
-  }: {
-    instrumentationService: IInstrumentationService;
-    authenticationService: IAuthenticationService;
-    transactionManagerService: ITransactionManagerService;
-    toggleTodoUseCase: IToggleTodoUseCase;
-    deleteTodoUseCase: IDeleteTodoUseCase;
-  }) =>
+  (
+    instrumentationService: IInstrumentationService,
+    authenticationService: IAuthenticationService,
+    transactionManagerService: ITransactionManagerService,
+    toggleTodoUseCase: IToggleTodoUseCase,
+    deleteTodoUseCase: IDeleteTodoUseCase
+  ) =>
   async (
     input: z.infer<typeof inputSchema>,
     sessionId: string | undefined