Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #4327: Outputs of code not visible in Guide #325

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

webermayank
Copy link
Contributor

Description

Fixes issue - nightwatchjs/nightwatch#4327

Fixed the issue of output not showing in Guide sections

Screenshots of Solved Issue

fixed for - https://nightwatchjs.org/guide/running-tests/catch-js-exceptions.html

  • Click on link -> scroll down
    Screenshot 2024-12-09 191116

fixed for - https://nightwatchjs.org/guide/configuration/define-test-environments.html

  • Click on link -> scroll down
    Screenshot 2024-12-09 191545

Explanation

I have done some changes in the code like

  • removed ``` and added <code> inside <pre>
  • Define language class in <code> and <pre> to specify the language of the code
  • replaced some < with &lt; and > with &gt; because it can not be possible to write < or > inside <code> tag due to html rendering: The server was processing the code lines inside the code block which we do not want.

@garg3133 please review this

@garg3133
Copy link
Member

Thanks for the PR, @webermayank! I've added it to my todo list and will review it soon.

@garg3133 garg3133 merged commit 7f7b1fc into nightwatchjs:versions/3.0 Jan 15, 2025
@garg3133
Copy link
Member

garg3133 commented Jan 15, 2025

Merged, thanks a lot for working on this @webermayank!

The changes will soon be live on https://dev.nightwatchjs.org, please verify over there.

@webermayank
Copy link
Contributor Author

@garg3133
Yes it is working perfectly on https://dev.nightwatchjs.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants