-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: security vulnerability issues #26
Conversation
@garg3133 can you review this? |
package.json
Outdated
"overrides": { | ||
"semver": "^7.5.3" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using this, just install the latest version of nightwatch
. That should fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get like install latest nightwatch version?
It will be according to version mentioned in package.json
can you help out a little for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just do npm i -D nightwatch@latest
and npm un -D @types/nightwatch
(types are automatically included in the latest version of Nightwatch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you , I have added the changes with resolving for one more moderate package issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this severe issues are remaining ,on updating which breaking changes are occuring
@AkhilJ321 What did you do for "update debug package to 4.3.1 for adkit package."? I don't see any change related to the debug package. |
@garg3133 ,debug package was related to a specific dependency , so I made changes in the package.lock.json for that package. |
|
@AkhilJ321 We should never make changes to On a side note, the changes done in The next steps here would be to create a new PR (from a fresh branch) and the for every step you follow, create a separate commit for it. For ex. one commit for just |
Okay,thank you for the reviews .I will make a PR soon |
Used
npm audit fix
to resolve low priority issues.1.Fixed issue for 'semver' by creating a override
Issue Related: #21