This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Update to CMake 3.7.1 - but not only #5
Open
pboettch
wants to merge
70
commits into
nickhutchinson:master
Choose a base branch
from
pboettch:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the help of blow
He is right, though.
- configure_package_config_file - write_basic_package_version_file
use manually created JSON-file to get Doxygen-keywords and commands
cmakeArguments syntax region used "contains=ALLBUT" which, in particular, made it contain "@spell", i.e. told the spell checked to check everything inside the function arguments. This was undesirable, as can be seen with the following simple example cmake_minimum_required(VERSION 3.1) # This should be spel-checked. set(this_should_not_be_spel_checked "some value") in which "spell" misspelling was highlighted in both places and not just in the first one. Fix this by explicitly excluding @spell from cmakeArguments and, to compensate for the text inside the string used in the arguments not being spell-checked any more, add it to cmakeString explicitly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nick,
Without telling you (via a pull-request) I continued your idea but changed it to extract even more data from the cmake-doc. I also added more highlighting options.
In addition to that I asked the cmake-folks to integrate these new cmake-syntax version and they did. A newer version is included in 3.7.x. (Just check for your name on
/usr/share/cmake-3.7/editors/vim/syntax/cmake.vim
if you already have cmake 3.7).Please merge if you like.