Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ViewModelProviders #797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cerberusv2px
Copy link

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Removed ViewModelProviders.of() with ViewModelProvider() since its deprecated in the newer version

💡 Motivation and Context

Deprecated code

💚 How did you test it?

Manual testing and ran all test with command ./gradlew test

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

📸 Screenshots / GIFs

@florina-muntenescu
Copy link
Collaborator

At least some of these changes were addressed already by a different PR. Would you mind rebasing, please?

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants