Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PlayCore and In-App Updates #746

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keyboardsurfer
Copy link
Collaborator

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add In-App Update logic to the project

💡 Motivation and Context

Prepare In-App Update skeleton implementation.

#703

💚 How did you test it?

Manually using the Internal App Sharing track.

📝 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Implement #703 UI changes.

📸 Screenshots / GIFs

Use for all types of ViewHolders that can be displayed within
the FeedAdapter.

Also moving out DribbbleShotHolder into its own class simplifies FeedAdapter.
@keyboardsurfer
Copy link
Collaborator Author

Instead of our own implementation we should be using com.google.android.play:core-ktx:1.6.4 by now.

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants