Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite package update date when publishing #50

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Overwrite package update date when publishing #50

merged 1 commit into from
Mar 10, 2024

Conversation

nicfv
Copy link
Owner

@nicfv nicfv commented Mar 10, 2024

No description provided.

@nicfv nicfv added bug Something isn't working documentation Improvements or additions to documentation ci Continuous integration labels Mar 10, 2024
@nicfv nicfv merged commit 6a73ab4 into main Mar 10, 2024
1 check passed
@nicfv nicfv deleted the dev branch March 10, 2024 22:52
@nicfv
Copy link
Owner Author

nicfv commented Mar 10, 2024

The issue is that when publishing a package, we call npm v package time.modified before publishing, so it is using the last version's publish timestamp. We could run another npm v package, however it's much easier and faster to get the timestamp through date +%s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ci Continuous integration documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicfv