Add codegen support for Daqmx Write apis which have multiple in params. #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse on moniker out param
…m/ni/grpc-device into users/rrawat/multiple_param_daqmx_write_apis
…rawat/multiple_param_daqmx
…m/ni/grpc-device into users/rrawat/multiple_param_daqmx_write_apis
Raghav-NI
requested review from
reckenro,
astarche and
maxxboehme
as code owners
reckenro
reviewed
Nov 26, 2024
reckenro
approved these changes
Nov 26, 2024
doshirohan
approved these changes
Nov 27, 2024
doshirohan
reviewed
Nov 27, 2024
added 2 commits
November 27, 2024 22:38
…rawat/multiple_param_daqmx_write_apis
amehra-ni
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds codegen support for remaining Daqmx Write apis which have multiple in params.
Why should this Pull Request be merged?
Generated streaming counterpart for all the remaining Daqmx write apis needed for streaming.
What testing has been done?
I am able to build and ran server without any errors. We will test the apis with the integration test we are working on.