Add codegen support for Daqmx Read apis which have multiple out params. #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse on moniker out param
Raghav-NI
requested review from
reckenro,
astarche and
maxxboehme
as code owners
reckenro
reviewed
Nov 25, 2024
Base automatically changed from
users/indoshir/add-request-response-to-stream-api
to
main
November 26, 2024 11:32
added 2 commits
November 26, 2024 19:02
…rawat/multiple_param_daqmx
Raghav-NI
force-pushed
the
users/rrawat/multiple_param_daqmx
branch
from
e2d17b1 to
d3ea52a
Compare
reckenro
approved these changes
Nov 26, 2024
doshirohan
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds codegen support for remaining Daqmx Read apis which have multiple out params. The generation logic for multiple out params in response has been done as part of Rohan's PR
Why should this Pull Request be merged?
What testing has been done?
I am able to build and ran server without any errors. We will test the apis with the integration test we are working on.