Update grpc-device to have support for Add Offset Nulling Calibration #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeborahOoi96
requested review from
reckenro,
astarche and
maxxboehme
as code owners
zhindes
approved these changes
Jan 10, 2024
maxxboehme
approved these changes
Jan 10, 2024
That's fine. What happened was this scrapigen PR changed the Self-Cal functions.py values but it was tested then and since it didn't have any .proto changes in grpc-device it wasn't merged into this repo yet. It's fine that it's being brought over now. |
reckenro
reviewed
Jan 10, 2024
astarche
approved these changes
Jan 11, 2024
bkeryan
requested changes
Jan 11, 2024
bkeryan
reviewed
Jan 12, 2024
bkeryan
reviewed
Jan 12, 2024
bkeryan
reviewed
Jan 12, 2024
bkeryan
requested changes
Jan 16, 2024
bkeryan
approved these changes
Jan 18, 2024
DeborahOoi96
force-pushed
the
users/deooi/grpc-device
branch
from
365b29a to
54299cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Shows the result of the changes in grpc-device-scrapigen pr
Codegen nidaqmx.proto file which will be used in nidaqmx-python PR
Expected error test coverage added for offset nulling calibration tests in grpc-device because the devices in grpc-device functional test do not support offset nulling calibration. Discussion thread here.
Why should this Pull Request be merged?
Adds support for Offset Nulling Calibration in grpc devices
What testing has been done?
Built successfully, files codegened are as expected.
All tests passed as seen in PR build.