Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generation for 16-bit block moves #1007

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

dmondrik
Copy link
Contributor

@dmondrik dmondrik commented Oct 4, 2023

What does this Pull Request accomplish?

  • It fixes code generation for 16-bit block moves. The previously generated code just casted the buffer pointer, which is wrong.
  • It includes the latest function metadata exported from scrapigen.

Why should this Pull Request be merged?

  • Writing a buffer using a 16-bit array as an input parameter can be auto generated easily. There were other instances where it performed this for ViInt16[] so I just added ViUInt16[] to those cases.
  • Reading a buffer using a 16-bit array as an output parameter is not a case that had been considered. Chatting with Ryan, it doesn't feel there would be sufficient reuse to warrant handling it in code generation. So I moved that method to the custom service code.

What testing has been done?

We plan to add auto tests in a follow-on PR for these and other register based methods. Hopefully that will be OK.

@dmondrik dmondrik merged commit a83beaf into main Oct 5, 2023
@dmondrik dmondrik deleted the users/danrm/fix-move-16 branch October 5, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants