Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for deleting attributes from a Variant and fixed bugs with outputs no wired #588

Merged
merged 4 commits into from
Mar 21, 2019
Merged

Added test for deleting attributes from a Variant and fixed bugs with outputs no wired #588

merged 4 commits into from
Mar 21, 2019

Conversation

cglzaguilar
Copy link
Contributor

No description provided.

spathiwa
spathiwa approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@spathiwa spathiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

sanmut
sanmut suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@sanmut sanmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall great. Thanks for catching all optional arguments and adding tests too :-)

source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
source/core/Variants.cpp Outdated Show resolved Hide resolved
sanmut
sanmut approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@sanmut sanmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback from multiple reviews :-)

source/core/Variants.cpp Show resolved Hide resolved
@sanmut sanmut merged commit 4f6d5ce into ni:master Mar 21, 2019
@cglzaguilar cglzaguilar deleted the variantDeleteAttributes branch April 11, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmut sanmut sanmut approved these changes

@spathiwa spathiwa spathiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cglzaguilar @spathiwa @sanmut