Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vireo EggShell Refactor for Supporting More Types #471

Merged
merged 70 commits into from
Jul 13, 2018
Merged

Vireo EggShell Refactor for Supporting More Types #471

merged 70 commits into from
Jul 13, 2018

Commits on Jul 10, 2018

  1. Add the findValueRef API function

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    167e818 View commit details
    Browse the repository at this point in the history

  2. Update readDouble for ValueRef api

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    c4fbfd7 View commit details
    Browse the repository at this point in the history

  3. Add the shared createValueRef function

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    493d545 View commit details
    Browse the repository at this point in the history

  4. Fix usage of createValueRef

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7fa3d60 View commit details
    Browse the repository at this point in the history

  5. Test unsupported types for readDouble

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    ce1727c View commit details
    Browse the repository at this point in the history

  6. Merged changes for readDouble

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e69710c View commit details
    Browse the repository at this point in the history

  7. Exported more Is* functions from TypeCommon

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    20c171c View commit details
    Browse the repository at this point in the history

  8. Merged isType functions

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    56d5567 View commit details
    Browse the repository at this point in the history

  9. Added tests for reflectOnValueRef and fixed some issues.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f303d55 View commit details
    Browse the repository at this point in the history

  10. Fixed whitespace in EmMakeFile and removed cwrap for TopAQSize.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    d58340d View commit details
    Browse the repository at this point in the history

  11. Moved all type related functions to its own module. 

    Also addressed feedback from the PR.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    b7c830f View commit details
    Browse the repository at this point in the history

  12. Fixed linting issues

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    6db6834 View commit details
    Browse the repository at this point in the history

  13. Modified TypeRef_Name to take a TypeManagerRef as other similar funct… 

    …ions
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    5f812dc View commit details
    Browse the repository at this point in the history

  14. Removed string allocations for errors

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    cfd90b0 View commit details
    Browse the repository at this point in the history

  15. Moved v_root and v_userShell

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    9d732e7 View commit details
    Browse the repository at this point in the history

  16. Added findSubValueRef

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    440a175 View commit details
    Browse the repository at this point in the history

  17. Added tests for FindSubValueRef

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    caa3ca8 View commit details
    Browse the repository at this point in the history

  18. Moved readDouble function in eggShell 

    Now is next to writeDouble
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    3c6658e View commit details
    Browse the repository at this point in the history

  19. Added a little more validation to FindSubValue

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7ec6613 View commit details
    Browse the repository at this point in the history

  20. Added InvalidTypeRef as an EggShellResult 

    Addressed feedback.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    6e61e37 View commit details
    Browse the repository at this point in the history

  21. Changed top-level test description

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    89b024b View commit details
    Browse the repository at this point in the history

  22. First pass at string read

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    285aafa View commit details
    Browse the repository at this point in the history

  23. Enable all tests

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    c95bfdd View commit details
    Browse the repository at this point in the history

  24. Move type functions to new module

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    357a758 View commit details
    Browse the repository at this point in the history

  25. Expand types for readTypedArray

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    9978769 View commit details
    Browse the repository at this point in the history

  26. Fix cpplint error

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    a500383 View commit details
    Browse the repository at this point in the history

  27. Change Data_GetArrayBegin to return pointer 

    Was casting pointer to Int32 to emphasize 32-bit JS API behavior, but as 64-bit builds of Vireo and C API usage are possible changed to void* as return type.
    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    deefc47 View commit details
    Browse the repository at this point in the history

  28. Add boolean array support for readTypedArray

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    3b526c1 View commit details
    Browse the repository at this point in the history

  29. Fix GetNumericArray test for new variable name

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    8c3eee6 View commit details
    Browse the repository at this point in the history

  30. Use readTypedArray for HttpPost buffer

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e200e3e View commit details
    Browse the repository at this point in the history

  31. Fix Makefile whitespace

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    289aad2 View commit details
    Browse the repository at this point in the history

  32. Cover unsupported cases for readString and getArrayDimensions

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    38f6b95 View commit details
    Browse the repository at this point in the history

  33. Merged typeRank and elementName

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    4327ab0 View commit details
    Browse the repository at this point in the history

  34. Initial implementation of readValueRefObject with tests

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7563590 View commit details
    Browse the repository at this point in the history

  35. Added some more validation for accepted types of readValueRefObject.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    93713db View commit details
    Browse the repository at this point in the history

  36. Updated error for readValueRefObject

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e365f83 View commit details
    Browse the repository at this point in the history

  37. Added note on typeHandlers order.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    800ca42 View commit details
    Browse the repository at this point in the history

  38. Added a few more comments to explain order of typeHandlers

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    129c512 View commit details
    Browse the repository at this point in the history

  39. Added tests for NIPath

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    17bffae View commit details
    Browse the repository at this point in the history

  40. Resize array initial implementation

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    9524c9d View commit details
    Browse the repository at this point in the history

  41. Move Rank validation to Cpp layer

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    c761212 View commit details
    Browse the repository at this point in the history

  42. Move valid array type check to cpp

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    d9755cc View commit details
    Browse the repository at this point in the history

  43. Fix cpp lint error

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    070a00c View commit details
    Browse the repository at this point in the history

  44. Updated EggShell_ReadValueString to use type and data pointers. 

    This function returns an EggShellResult for error handling.
Updated all tests where readJSON was used.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    6ccce6e View commit details
    Browse the repository at this point in the history

  45. Deleted HelloNode.js 

    We now have tests for FPSync and extensive coverage for readJSON and writeJSON.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f816bcb View commit details
    Browse the repository at this point in the history

  46. Added UnableToParseData to eggShellResultEnum

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    4282813 View commit details
    Browse the repository at this point in the history

  47. Fixed tests for new writeJSON API. 

    There are still a few tests failing we need to address.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    b324a8d View commit details
    Browse the repository at this point in the history

  48. Fixed remaining broken tests 

    Added const to TypeRef in EggShell_[Write|Read]ValueString too.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    44724a8 View commit details
    Browse the repository at this point in the history

  49. First pass of writeString

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    a905e11 View commit details
    Browse the repository at this point in the history

  50. Update comment for jsStringToSizedUTF8Array

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    cc225b8 View commit details
    Browse the repository at this point in the history

  51. Expand readString and writeString tests

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    d59084d View commit details
    Browse the repository at this point in the history

  52. First pass writeDouble api

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    b14bda8 View commit details
    Browse the repository at this point in the history

  53. Expand writeDouble tests and use EggShellResult

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    5eb6d59 View commit details
    Browse the repository at this point in the history

  54. Aded visitEnum[8|16|32] to visitor reflection API

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    4f8a8e2 View commit details
    Browse the repository at this point in the history

  55. Changed name of visitor functions for enums 

    Also added a test for unssported Enums of 64 bits.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    0e9519d View commit details
    Browse the repository at this point in the history

  56. Mark deprecated functions in eggShell api

    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e9e9b21 View commit details
    Browse the repository at this point in the history

  57. Standardized on call for dispatchers and fixed loop condition.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7004589 View commit details
    Browse the repository at this point in the history

  58. Added tests for context and arguments of visitor functions.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    72050a1 View commit details
    Browse the repository at this point in the history

  59. Merge pull request #2 from gleonoliva/typehelpers-fixes 

    Standardized on call for dispatchers and fixed loop condition.
    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f391fd4 View commit details
    Browse the repository at this point in the history

  60. Renamed TypeWaveform tests to be included in the test suite.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    ae135ca View commit details
    Browse the repository at this point in the history

  61. Fixed tests in TypeWaveform. 

    Timestamps are 2 UInt64 therefore their JSON representation are strings.
Updating expected values to match this.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    9db209f View commit details
    Browse the repository at this point in the history

  62. Fixing FindSubValueRef 

    Also added tests that verify this behavior.
    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    e79f1e3 View commit details
    Browse the repository at this point in the history

  63. Fixed linting errors

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    c01c7e2 View commit details
    Browse the repository at this point in the history

  64. Renamed tests

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    558ff6f View commit details
    Browse the repository at this point in the history

  65. Reverted writeJSStringToStack and added a free memory on writeJSON.

    @rajsite
    Guillermo León authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    32b5f73 View commit details
    Browse the repository at this point in the history

  66. Merge pull request #3 from gleonoliva/read-write-json-tests 

    fix for findSubValueRef.
I added tests that effectively fail before the fix and pass after making it.
Included is the renaming of TypeWaveform.test.js to TypeWaveform.Test.js which were not being executed because of the regex used in karma.conf to include tests. I also fixed those.
    @rajsite
    rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    48562fd View commit details
    Browse the repository at this point in the history

  67. Type support feedback (#4) 

    * Adressed feedback from PR

* Renamed subpathstackPointer

* Fixing typo, variable names and TypeManagerScope for FindValue.

* Renamed pData in header
    @rajsite
    Guillermo Leon authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    1eef26c View commit details
    Browse the repository at this point in the history

  68. Type support feedback5 (#5) 

    * Changed test names to from types to values to keep them consistent

* Added an extra line at the end to remove red marker

* Improving readibility by having signed type checks in same line
    @rajsite
    Guillermo Leon authored and rajsite committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7754218 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Use decoded field names in readValueRefObject

    @rajsite
    rajsite committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    8498742 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #6 from rajsite/valuerefobject-decoded-names 

    Use decoded field names in readValueRefObject
    @rajsite
    rajsite authored Jul 11, 2018
    Configuration menu
    Copy the full SHA
    80c9e0f View commit details
    Browse the repository at this point in the history