Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass hasura's env vars to the hasura console #768

Closed
wants to merge 1 commit into from

Conversation

atbe
Copy link
Contributor

@atbe atbe commented Sep 14, 2023

Description

chore: Pass all environment variables to "console" service for local testing

Problem

Events using environment variables can't be locally tested due to these variables not being available in the "console" service defined in the docker-compose file.

Solution

This PR modifies the docker-compose file generator to include all environment variables, making them accessible to the "console" service. This allows for easier local testing of events dependent on these variables.

Notes

Exercise caution with sensitive information; make sure to filter out sensitive environment variables before they are passed to the "console" service.

@dbarrosop dbarrosop changed the title Pass all env vars to console. fix: pass hasura's env vars to the hasura console Sep 14, 2023
@dbarrosop
Copy link
Member

Thanks for the fix, the changes look good but the tests are broken, would you mind fixing? Thanks!

@atbe
Copy link
Contributor Author

atbe commented Sep 14, 2023

@dbarrosop I would be happy to, but the output of the tests are unclear and don't give me any indication of what's failing, and the tests are failing to run on a Mac where they throw an error:

error: flake 'git+file:///Users/ibrahimahmed/code/nhost-projecrs/nhost-cli' does not provide attribute 'packages.x86_64-darwin.default' or 'defaultPackage.x86_64-darwin'

If you could kindly fix the error, I would really appreciate it, otherwise I'll fire up a linux machine to try to get it fixed.

@dbarrosop
Copy link
Member

You should be able to just run go test ./... if needed

@dbarrosop
Copy link
Member

Merged via 2aff9fd

@dbarrosop dbarrosop closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants