Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned and tidied code. Added basic firestore service support. #83

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emrothenberg
Copy link

  • Added Firestore support: Introduced basic functionality for interacting with Firestore, enabling read and update operations through the Pyrebase4 library, with option to add create and delete for complete CRUD support.
  • Code cleanup and refactoring: Improved code readability and maintainability by cleaning and tidying up existing code.

@nhorvath
Copy link
Owner

What were the material changes to the files that show completely changed? I prefer commits that use a linter for the first time to have no code changes so they can be ignored.

@emrothenberg
Copy link
Author

  1. Created a "services" module and moved all the services there (auth, database, storage),
  2. Moved non-service classes to new module "types"
  3. Created "utils" module to populate repeatedly used functions, since now not all elements are in the same file
  4. Added a new service to include Firestore in services/firestore.py. This is the only functional change.
  5. All changes after the first commit were only done to the firestore file, as well as updating the README to document functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants