MSVC-specific Empty Baseclass Optimization activation. #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures sizof(unit type) is the same as sizeof(underlying_type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures sizof(unit type) is the same as sizeof(underlying_type), which was not the case on Windows on the v3.x branch.
Without that fix I observed sizeof(meters) to be 8 as each units base class contributes at least one byte on top of the 4 bytes of a float.
According to this answer, that fix is valid since Visual Studio 2017 Update 2, which seems acceptable to me in term of backward compatibility for the new branch?
Extended test coverage accordingly.