WIP Add support for BeginTransactionAsync #3139
Conversation
| { | ||
| if (isolationLevel == IsolationLevel.Unspecified) | ||
| { | ||
| return connection.BeginTransactionAsync(cancellationToken); |
There was a problem hiding this comment.
@maca88 I tried to fix this by using 'alwaysAwait' option, but I could not quite figure out the syntax.
There was a problem hiding this comment.
To fix this change the alwaysAwait section to:
alwaysAwait:
- name: BeginTransaction
The filter BeginTransactionAsync could also work but the containingTypeName filter would need to be changed from AsyncExtensions to DriverBase.
There was a problem hiding this comment.
How does it work? I thought it identifies the method that should be always awaited.
There was a problem hiding this comment.
With alwaysAwait you define filters that are applied on every generated async method to check whether to force await invocations inside the method body. So if we take the above filter as an example, every generated async method that has a sync counterpart named BeginTransaction will be generated by using async/await even if some of them could be generated without it.
No description provided.