Use table group joins for many-to-many in Criteria and Entity loaders

[bahusoid]

Cons: query is executed for each not found element for not filtered collection for Criteria (so not ideal when not-found="ignore"). But it's the same behavior for LINQ and lazy loading. I will try to address it in separate PR (hibernate uses inner join for many-to-many lazy loading so basically always ignores not found records)

Pros: Removes some hacks (like BasicCollectionPersister.ManyToManySelectFragment) and unifies behavior between LINQ, Criteria and entity loaders.

Possible breaking change: Default not-found behavior now works correctly so now it throws ObjectNotFoundException exception on many-to-many Criteria fetch for not found records.

[fredericDelaporte]

When testing with the new tests but without NHibernate changes, only the queryover test in NH750 fails. All other tests succeeds, included the lazy loading one. Your description seems to imply the "lazy load with throws for not found" test should have failed without your change.

Could you rebase this branch? It appears to be based on a quite old master dating back to the the start of the year.

[bahusoid]

only the queryover test in NH750 fails.

Good catch. Indeed, lazy loading is not affected by this bug as GetSelectFragment overload with rhsAlias is not used there (

nhibernate-core/src/NHibernate/Loader/Collection/BasicCollectionJoinWalker.cs

Line 74 in d32a9d9

.SetSelectClause(collectionPersister.GetSelectFragment(alias, CollectionSuffixes[0]).ToSqlStringFragment(false)

)

I updated description.