Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use supported package for slack #14

Merged
merged 1 commit into from
May 12, 2020
Merged

use supported package for slack #14

merged 1 commit into from
May 12, 2020

Conversation

alek13
Copy link
Contributor

@alek13 alek13 commented May 11, 2020

@ngraf
Copy link
Owner

ngraf commented May 12, 2020

Thanks for raising this issue. I will have a look.

I don't have a test suite for my extension. I don't use this extension in my daily life as well.
All I could do is code review of the two classes that I use from "maknz/slack". From what I have seen, there should be no breaking change when I switch to "alek13/slack".

@ngraf ngraf merged commit 3ca659f into ngraf:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alek13 @ngraf